feat(33792): Add quick fix for `This condition will always return true since the function is always defined. Did you mean to call it instead - #37152
Merged
Andrew Casey (amcasey) merged 2 commits intoMar 13, 2020
Conversation
Contributor
|
Fixes #37149? |
Nathan Shively-Sanders (sandersn)
added
the
For Uncommitted Bug
Nathan Shively-Sanders (sandersn)
requested review from
Andrew Casey (amcasey) and
Andrew Branch (andrewbranch)
March 12, 2020 16:47
Andrew Casey (amcasey)
suggested changes
Mar 12, 2020
Andrew Casey (amcasey)
left a comment
Andrew Casey (amcasey)
left a comment
Member
There was a problem hiding this comment.
I can't wait to have this code fix, but I do have one concern.
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
feature/33792
branch
from
March 13, 2020 09:03
30dc54d to
756f76a
Compare
Oleksandr Tarasiuk (a-tarasyuk)
requested review from
Andrew Casey (amcasey) and
Ron Buckton (rbuckton)
March 13, 2020 09:06
Andrew Casey (amcasey)
approved these changes
Mar 13, 2020
Member
|
Ron Buckton (@rbuckton) Andrew Branch (@andrewbranch) Last call for comments |
Contributor
|
Good work on the tests 👍 |
Andrew Branch (andrewbranch)
approved these changes
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33792