fix(36102): fix extra new line in Organize Imports - #36911
Merged
Eli Barzilay (elibarzilay) merged 1 commit intoMar 12, 2020
Conversation
Nathan Shively-Sanders (sandersn)
added
the
For Milestone Bug
Nathan Shively-Sanders (sandersn)
requested a review
from Eli Barzilay (elibarzilay)
March 2, 2020 20:15
Member
|
Eli Barzilay (@elibarzilay) mind taking a look at this PR? |
Member
|
Andrew Branch (@andrewbranch) is this related to #36688 ? |
Member
|
It is not. |
Alaa Saleh (photonite)
approved these changes
Mar 3, 2020
Eli Barzilay (elibarzilay)
suggested changes
Mar 3, 2020
Eli Barzilay (elibarzilay)
left a comment
Eli Barzilay (elibarzilay)
left a comment
Contributor
There was a problem hiding this comment.
Another thing is to add tests (but TBH when I looked at that the tests I've seen compare lists of imports rather than the generated text).
Sachin Grover (sacgrover)
force-pushed
the
extra-line
branch
from
March 4, 2020 19:38
2bc044e to
3fe5008
Compare
Organize Imports was inserting extra newline. Fixes microsoft#36102
Eli Barzilay (elibarzilay)
force-pushed
the
extra-line
branch
from
March 12, 2020 20:33
3fe5008 to
0b0d6e7
Compare
Eli Barzilay (elibarzilay)
approved these changes
Mar 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organize Imports was inserting extra newline.
Fixes #36102