Set correct pos for NamespaceExport - #36794
Merged
Andrew Branch (andrewbranch) merged 2 commits intoFeb 14, 2020
Merged
Conversation
Andrew Branch (andrewbranch)
requested review from
Wenlu Wang (Kingwl) and
Nathan Shively-Sanders (sandersn)
February 14, 2020 00:07
Wenlu Wang (Kingwl)
approved these changes
Feb 14, 2020
Wenlu Wang (Kingwl)
left a comment
Wenlu Wang (Kingwl)
left a comment
Contributor
There was a problem hiding this comment.
My fault, thanks
Sheetal Nandi (sheetalkamat)
approved these changes
Feb 14, 2020
Wesley Wigham (weswigham)
approved these changes
Feb 14, 2020
Andrew Branch (andrewbranch)
added a commit
to andrewbranch/TypeScript
that referenced
this pull request
Feb 14, 2020
* Set correct pos for NamespaceExport * Update tests
Nathan Shively-Sanders (sandersn)
approved these changes
Feb 14, 2020
Daniel Rosenwasser (DanielRosenwasser)
pushed a commit
that referenced
this pull request
Feb 14, 2020
Andrew Branch (andrewbranch)
added a commit
that referenced
this pull request
Feb 28, 2020
* Fix renaming an ExportSpecifier name when propertyName is present (#36790) * Fix renaming exportSpecifier name when propertyName is present * Add baseline test for name without propertyName too * Set correct pos for NamespaceExport (#36794) * Set correct pos for NamespaceExport * Update tests * Cherry-pick PR #37064 into release-3.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36762
Baseline changes verify this works, but the output of a simple script is easier to look at: