Support property declarations in jsdoc template generation - #36658
Merged
Nathan Shively-Sanders (sandersn) merged 2 commits intoFeb 6, 2020
Conversation
Nathan Shively-Sanders (sandersn)
requested review from
Andrew Branch (andrewbranch) and
Orta Therox (orta)
February 6, 2020 17:29
Member
Author
|
Ben Lichtman (@uniqueiniquity) Tagging you since github suggested you as a reviewer -- in case you care about this feature. |
| //// return p0; | ||
| //// }; | ||
| //// /*1*/ | ||
| //// bar = (p1) => { |
Contributor
There was a problem hiding this comment.
Should you also test the function expression case?
Member
Author
There was a problem hiding this comment.
Yes!
Andrew Branch (andrewbranch)
approved these changes
Feb 6, 2020
Member
Author
|
Build failed because of space lint. |
Member
Author
|
Relevant: Key to planet formation found in space lint: https://www.space.com/3315-key-planet-formation-space-lint.html |
Nathan Shively-Sanders (sandersn)
deleted the
jsdoc-template-for-property-decl
branch
February 6, 2020 22:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSDoc template generation now supports property declarations with function initialisers.
Fixes #28786