fix(33836): VSCode - generate accessors fixup on readonly field removes modifier - #36543
Merged
Jesse Trinity (jessetrinity) merged 2 commits intoMay 13, 2020
Merged
Conversation
Nathan Shively-Sanders (sandersn)
added
the
For Backlog Bug
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/33836
branch
from
March 11, 2020 10:10
2b5fabc to
ba62119
Compare
Oleksandr Tarasiuk (a-tarasyuk)
force-pushed
the
bug/33836
branch
from
April 10, 2020 08:26
f7ab85d to
b88a0b1
Compare
Jesse Trinity (jessetrinity)
self-requested a review
May 13, 2020 18:49
Jesse Trinity (jessetrinity)
approved these changes
May 13, 2020
Jesse Trinity (jessetrinity)
left a comment
Jesse Trinity (jessetrinity)
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
AllenLee (cangSDARM)
added a commit
to cangSDARM/TypeScript
that referenced
this pull request
May 14, 2020
* upstream/master: Perform intersection reduction before and after getApparentType (microsoft#38565) fix(33836): allow readonly modifier for a field with only get accessor (microsoft#36543) Fix build type error (microsoft#38525)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33836