Fixes JSX attribute escaping when parent pointers are missing - #35743
Merged
Conversation
Ron Buckton (rbuckton)
requested review from
Nathan Shively-Sanders (sandersn) and
Sheetal Nandi (sheetalkamat)
January 3, 2020 19:28
Nathan Shively-Sanders (sandersn)
approved these changes
Jan 9, 2020
| } | ||
|
|
||
| /** Given a symbol for a module, checks that it is a shorthand ambient module. */ | ||
|
|
There was a problem hiding this comment.
look like this diff happened by mistake
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Jan 24, 2020
Member
|
Ron Buckton (@rbuckton) is this ready to go in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures we use the correct character escaping mechanism when emitting a synthetic or unparented
StringLiteralthat is the initializer of aJsxAttribute.Fixes #35054