Skip to content

Type comparison when conditional type is target - #35741

Closed
Jack Bates (jablko) wants to merge 2 commits into
microsoft:mainfrom
jablko:patch-33
Closed

Type comparison when conditional type is target#35741
Jack Bates (jablko) wants to merge 2 commits into
microsoft:mainfrom
jablko:patch-33

Conversation

@jablko

@jablko Jack Bates (jablko) commented Dec 18, 2019

Copy link
Copy Markdown
Contributor

Alternative to #30639 and #27932 (and #27589) that fixes #23132, as well as #26933. The implementation is analogous to #30769.

Fixes #23132
Fixes #25413
Fixes #26933
Fixes #29505
Fixes #29662

@jablko
Jack Bates (jablko) force-pushed the patch-33 branch 3 times, most recently from d1c3ce2 to f67c607 Compare January 25, 2020 20:23
@sandersn Nathan Shively-Sanders (sandersn) added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 1, 2020
@jablko
Jack Bates (jablko) force-pushed the patch-33 branch 5 times, most recently from e381a49 to 9fb32ca Compare February 9, 2020 17:19
@jablko
Jack Bates (jablko) force-pushed the patch-33 branch 5 times, most recently from d7ef233 to fca56ca Compare February 13, 2020 15:42
@weswigham

Wesley Wigham (weswigham) commented Mar 10, 2020

Copy link
Copy Markdown
Member

This includes the same change as #37208, so should also fix #30706.

@weswigham Wesley Wigham (weswigham) mentioned this pull request Mar 16, 2020
Open
@weswigham

Wesley Wigham (weswigham) commented Mar 4, 2022

Copy link
Copy Markdown
Member

Jack Bates (@jablko) with all the other conditional type stuff merged, what parts of this do we still possibly need?

@sandersn

Nathan Shively-Sanders (sandersn) commented Jun 1, 2022

Copy link
Copy Markdown
Member

To help with PR housekeeping, I'm going to close this PR since it's pretty old now.

@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.