Bind typedef/enum on all assignment declaration kinds - #33240
Merged
Nathan Shively-Sanders (sandersn) merged 1 commit intoSep 4, 2019
Conversation
This fixes a crash on exports, but the code now handles all kinds returned from getAssignmentDeclarationPropertyAccessKind.
Nathan Shively-Sanders (sandersn)
requested a review
from Wesley Wigham (weswigham)
September 4, 2019 17:20
Nathan Shively-Sanders (sandersn)
changed the title
Sheetal Nandi (sheetalkamat)
approved these changes
Sep 4, 2019
Wesley Wigham (weswigham)
approved these changes
Sep 4, 2019
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this |
Member
Author
|
TypeScript Bot (@typescript-bot) cherry-pick this to release-3.6 |
Contributor
|
Hey Nathan Shively-Sanders (@sandersn), I've opened #33244 for you. |
TypeScript Bot (typescript-bot)
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Sep 4, 2019
Component commits: 339e132 Bind typedef/enum on all assignment decl kinds This fixes a crash on exports, but the code now handles all kinds returned from getAssignmentDeclarationPropertyAccessKind.
Nathan Shively-Sanders (sandersn)
pushed a commit
that referenced
this pull request
Sep 4, 2019
Component commits: 339e132 Bind typedef/enum on all assignment decl kinds This fixes a crash on exports, but the code now handles all kinds returned from getAssignmentDeclarationPropertyAccessKind.
Nathan Shively-Sanders (sandersn)
deleted the
bind-typedef-on-all-assignments
branch
September 4, 2019 20:36
|
Wow, amazing response time Nathan Shively-Sanders (@sandersn)! Thanks for the super quick fix! :) |
Member
Author
|
Well, we are actively fixing 3.6 crashes since it's a new release. It should be out in less than a week as |
Nathan Shively-Sanders (sandersn)
added a commit
that referenced
this pull request
Sep 5, 2019
This reverts commit b542bdf.
Wesley Wigham (weswigham)
added a commit
to weswigham/TypeScript
that referenced
this pull request
Sep 5, 2019
…)" This reverts commit b542bdf.
Tim Suchanek (timsuchanek)
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
This fixes a crash on exports, but the code now handles all kinds returned from getAssignmentDeclarationPropertyAccessKind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash on exports, but the code now handles all kinds returned from getAssignmentDeclarationPropertyAccessKind.
Fixes #33230