Higher order this parameter inference, like #31116 - #33139
Closed
Jack Bates (jablko) wants to merge 2 commits into
Closed
Higher order this parameter inference, like #31116#33139Jack Bates (jablko) wants to merge 2 commits into
Jack Bates (jablko) wants to merge 2 commits into
Conversation
Jack Bates (jablko)
force-pushed
the
patch-8
branch
from
September 22, 2019 19:50
3d2c8c5 to
36e17f6
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
from
September 26, 2019 01:44
36e17f6 to
f91ec46
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
3 times, most recently
from
October 9, 2019 16:37
88d37ff to
f2ee891
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
2 times, most recently
from
October 19, 2019 18:34
42363a4 to
1dcdbda
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
from
October 27, 2019 19:15
1dcdbda to
0cd7a40
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
from
November 4, 2019 15:21
0cd7a40 to
9bcbe8d
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
2 times, most recently
from
November 16, 2019 15:24
aadc185 to
4065598
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
5 times, most recently
from
November 28, 2019 14:51
2154081 to
14d6b45
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
from
November 29, 2019 22:25
14d6b45 to
e7586e4
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
from
December 28, 2019 17:09
e7586e4 to
ba4a8fc
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
3 times, most recently
from
January 25, 2020 20:23
8918d43 to
b135f09
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
from
January 29, 2020 01:05
b135f09 to
fb70ce1
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
5 times, most recently
from
February 9, 2020 17:19
fd96594 to
b2b2bf8
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
5 times, most recently
from
February 13, 2020 15:42
02c53f0 to
84cb8d9
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
from
February 21, 2020 00:06
84cb8d9 to
aba956f
Compare
Jack Bates (jablko)
force-pushed
the
patch-8
branch
from
February 22, 2020 22:41
aba956f to
3c5a182
Compare
Nathan Shively-Sanders (sandersn)
self-requested a review
March 10, 2020 20:27
Member
|
Unfortunately, we never finished reviewing this PR. It is pretty old now, so I'm going to close it to reduce the number of open PRs. |
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following works since #31116/be88d53ab37453585b449b6ab1918134087b03cf
however the following is still
error TS2322: Type 'unknown' is not assignable to type 'number'.Consequently while
works, the following
is
error TS2322: Type 'unknown[]' is not assignable to type 'bigint[]'.(with--strictBindCallApply).The following
is
error TS2571: Object is of type 'unknown'.This PR extends #31116 to the
thisparameter so the second casefunction(this, value)behaves like the firstfunction call(fn, value).This improves type inference for
--strictBindCallApplyand generic functions and resolves the errors in both of the aboveArray.prototype.map.call()examples.