Defer resolution of conditional types with generic check or extends types - #28851
Merged
Conversation
Anders Hejlsberg (ahejlsberg)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Wesley Wigham (weswigham)
December 4, 2018 21:26
Wesley Wigham (weswigham)
approved these changes
Dec 4, 2018
Wesley Wigham (weswigham)
left a comment
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
With this change, distributivity is down to only affecting conditional type instantiation and constraints (which mostly follow from instantiation). I like more things not making the distinction between the distributive/nondistributive variants.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we always defer resolution of conditional types when one or both of the check and extends types are generic (as determined by
TypeFlags.Instantiable). Now, only when neither is generic do we perform further assignability checks to see if we can resolve a conditional type.Fixes #28824.