Skip to content

Make the assignability rule for conditional types require the check types and distributivity to be identical. - #27697

Merged
Ryan Cavanaugh (RyanCavanaugh) merged 1 commit into
microsoft:masterfrom
mattmccutchen:issue-27118
Feb 11, 2019
Merged

Make the assignability rule for conditional types require the check types and distributivity to be identical.#27697
Ryan Cavanaugh (RyanCavanaugh) merged 1 commit into
microsoft:masterfrom
mattmccutchen:issue-27118

Conversation

@mattmccutchen

@mattmccutchen Matt McCutchen (mattmccutchen) commented Oct 10, 2018

Copy link
Copy Markdown
Contributor

Fixes #27118.

Open
@mattmccutchen

Matt McCutchen (mattmccutchen) commented Oct 10, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) test this

I'm not even worthy of a rejection notice from the typescript-bot. ☹️

@weswigham

Wesley Wigham (weswigham) commented Oct 17, 2018

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this

He only responds to a MS org member/project owner's hails.

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 17, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Wesley Wigham (@weswigham), I've started to run the extended test suite on this PR at bc9b6d5. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Jan 24, 2019

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this again

@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 24, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at bc9b6d5. You can monitor the build here. It should now contribute to this PR's status checks.

@mattmccutchen

Matt McCutchen (mattmccutchen) commented Feb 9, 2019

Copy link
Copy Markdown
Contributor Author

Updated to master. This should remove the unrelated RWC differences.

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Feb 10, 2019

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this

@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Heya Ryan Cavanaugh (@RyanCavanaugh), I've started to run the extended test suite on this PR at 1aca1dd. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented Feb 11, 2019

Copy link
Copy Markdown
Member

RWC is green! 🎉

@RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) merged commit 2dfb620 into microsoft:master Feb 11, 2019
@ahejlsberg Anders Hejlsberg (ahejlsberg) mentioned this pull request Feb 13, 2019
Merged
@jack-williams Jack Williams (jack-williams) mentioned this pull request Feb 27, 2019
Closed
4 tasks
Nathan Shively-Sanders (sandersn) added a commit that referenced this pull request Feb 27, 2019
@sandersn
Revert "Merge pull request #27697 from mattmccutchen/issue-27118"
aedffe0 
This reverts commit 2dfb620, reversing
changes made to bbf559b.
Nathan Shively-Sanders (sandersn) added a commit that referenced this pull request Feb 27, 2019
@sandersn
Merge pull request #30133 from Microsoft/revert-conditional-type-inva…
0d93eb9 
…riance

Revert "Merge pull request #27697 from mattmccutchen/issue-27118"
@jack-williams Jack Williams (jack-williams) mentioned this pull request Feb 28, 2019
Merged
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattmccutchen @weswigham @typescript-bot @RyanCavanaugh