Add option --lazyConfiguredProjectsFromExternalProject to enable lazy load of configured projects referenced by external project - #26716
Conversation
… load of configured projects referenced by external project Fixes #26696
1c7319b to
96e6140
Compare
|
Sorry, I was unclear - I meant a programmatic switch (e.g. in Edit: Unless the server has to be restarted regardless? |
…f command line option
7b018ef to
fc90b8f
Compare
|
Andrew Casey (@amcasey) updated to user preferences |
Andrew Casey (amcasey)
left a comment
Andrew Casey (amcasey)
left a comment
There was a problem hiding this comment.
I think I'm just confused about scoping rules in TS. Otherwise, it looks good.
| @@ -1,3 +1,9 @@ | |||
| namespace ts { | |||
There was a problem hiding this comment.
Is this necessary? The one in protocol isn't visible?
There was a problem hiding this comment.
Thats because UserPreferences is moved to compiler and when building server it wont have lazyConfiguredProjectsFromExternalProject field. We add that only when building server. (UserPreferences is in ts namespace as appose to ts.server)
There was a problem hiding this comment.
changed it a bit to use protocol.UserPreferences
There was a problem hiding this comment.
Andy (Andrewkraft) (@Andy-MS) is more likely than I am to know what conventions we follow in this regard, but I find the new version clearer. Thanks!
| setTypeAcquisition(newTypeAcquisition: TypeAcquisition): void; | ||
| } | ||
| } | ||
| declare namespace ts { |
There was a problem hiding this comment.
I definitely feel like I'm missing something. What is this?
24e43b4 to
03bb5d1
Compare
|
Ryan Cavanaugh (@RyanCavanaugh) Is port to release-3.0 branch needed? |
|
Sheetal Nandi (@sheetalkamat) The original change (i.e. making loading lazy) wasn't ported to 3.0, was it? |
Oh right. Thanks |
2 participants
Fixes #26696