Infer array rest as tuple if possible - #26070
Merged
Ryan Cavanaugh (RyanCavanaugh) merged 4 commits intoOct 1, 2018
Merged
Conversation
Mohamed Hegazy (mhegazy)
requested review from
Anders Hejlsberg (ahejlsberg) and
Wesley Wigham (weswigham)
July 31, 2018 18:28
| var a3: any[]; | ||
| var [...a] = [1, 2, 3]; | ||
| var [x, ...a] = [1, 2, 3]; | ||
| ~ |
There was a problem hiding this comment.
I'd change the variable names at these new errors in this test so that you're comparing with the expected type and there's no error.
Wesley Wigham (weswigham)
approved these changes
Jul 31, 2018
Wesley Wigham (weswigham)
left a comment
Wesley Wigham (weswigham)
left a comment
Member
There was a problem hiding this comment.
❤️ These baseline updates look great. Small comments on improving the test output a bit, but it looks good to me.
Member
|
Will run this by Anders Hejlsberg (@ahejlsberg) tomorrow but I agree the baseline diffs indicate all goodness |
Member
|
"tomorrow" |
Member
|
Thanks Klaus Meinhardt (@ajafff) ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #26007
I hope this helps to decide if you want to accept #26007 as you can now see what baseline changes it causes.