Simplify parseJSDocIdentifierName - #24660
Merged
Nathan Shively-Sanders (sandersn) merged 2 commits intoJun 5, 2018
Merged
Conversation
It now always creates a missing node. The one place that depended on it returning undefined, parseJSDocTypeNameWithNamespace, now returns undefined before calling parseJSDocIdentifierName.
Deleted user (ghost)
approved these changes
Jun 4, 2018
| tag = parseUnknownTag(atToken, tagName); | ||
| break; | ||
| } | ||
| Debug.assert(!!tag); |
There was a problem hiding this comment.
Since we have --strictNullChecks now, this is statically typed to always be defined.
Member
Author
There was a problem hiding this comment.
Fixed
It is adequately proven at compile time.
Nathan Shively-Sanders (sandersn)
deleted the
simplify-parseJSDocIdentifierName
branch
June 5, 2018 21:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now always creates a missing node. The one place that depended on it returning undefined, parseJSDocTypeNameWithNamespace, now returns undefined before calling parseJSDocIdentifierName.
Based on Andy (Andrewkraft) (@Andy-MS)'s suggestion from the review of #24600.