Don't try to extract import to a method: simpler fix - #18054
Merged
Mohamed Hegazy (mhegazy) merged 1 commit intoAug 25, 2017
Merged
Conversation
ghost
requested a review
from Ryan Cavanaugh (RyanCavanaugh)
August 25, 2017 21:43
ghost
mentioned this pull request
Mohamed Hegazy (mhegazy)
approved these changes
Aug 25, 2017
Mohamed Hegazy (mhegazy)
deleted the
release-2.5_extract-method-not-for-import_better
branch
August 25, 2017 22:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simpler fix; in master we did both #18025 and #18047.