Return an object from completions-full - #17727
Closed
Andrew Casey (amcasey) wants to merge 1 commit into
Closed
Conversation
Simple completions return an array but full completions return an object (containing an array). We used to return null for both case when there were no completions to return, but in f124e19 we stopped returning `undefined` for requests that require a response. We started returning `[]` instead, in both cases, which caused problems when deserializing responses to `completions-full`. Instead, return `[]` for simple completions and and empty object (containing an empty array) for full completions.
Andrew Casey (amcasey)
requested review from
a user,
Mine Starks (minestarks) and
Ben Lichtman (uniqueiniquity)
August 10, 2017 18:36
|
Andrew Casey (@amcasey), |
Deleted user (ghost)
approved these changes
Aug 10, 2017
Mine Starks (minestarks)
approved these changes
Aug 10, 2017
Ben Lichtman (uniqueiniquity)
approved these changes
Aug 11, 2017
Member
Author
|
Looks like we're going back to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple completions return an array but full completions return an object
(containing an array). We used to return null for both case when there
were no completions to return, but in
f124e19 we stopped returning
undefinedfor requests that require a response. We started returning[]instead, in both cases, which caused problems when deserializingresponses to
completions-full. Instead, return[]for simplecompletions and and empty object (containing an empty array) for full
completions.
Fixes #