Add spread syntax to JsxExpression - #11591
Merged
Nathan Shively-Sanders (sandersn) merged 4 commits intoDec 22, 2016
Merged
Conversation
This allows you to specify that a JsxExpression should be a list that will be flattened by the JSX consumer.
And baselines
Member
Author
|
Yui (@yuit) Ryan Cavanaugh (@RyanCavanaugh) can one of you take a look at this? |
| if (node.expression) { | ||
| return checkExpression(node.expression); | ||
| const type = checkExpression(node.expression); | ||
| if (node.dotDotDotToken && !isArrayType(type)) { |
There was a problem hiding this comment.
Check for type being any
Member
Author
There was a problem hiding this comment.
done
Member
|
Needs tests for |
Member
Author
|
tsxSpreadChildrenInvalidType.tsx tests |
Member
Author
|
Ryan Cavanaugh (@RyanCavanaugh) I just noticed that I forgot about this. Is it good to go in? |
Mohamed Hegazy (mhegazy)
approved these changes
Dec 22, 2016
Contributor
|
Nathan Shively-Sanders (@sandersn) can you please refresh this PR. |
Nathan Shively-Sanders (sandersn)
deleted the
spread-jsx-expression-children
branch
December 22, 2016 22:24
| return checkExpression(node.expression); | ||
| const type = checkExpression(node.expression); | ||
| if (node.dotDotDotToken && type !== anyType && !isArrayType(type)) { | ||
| error(node, Diagnostics.JSX_spread_child_must_be_an_array_type, node.toString(), typeToString(type)); |
There was a problem hiding this comment.
These arguments are unused :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9495
This allows you to specify that a JsxExpression should be a list that will be flattened by the JSX consumer.
Thanks Yui (@yuit) for your 30-minute crash course on how the compiler handles JSX!