Skip to content

call hierarchy shows full file paths #36511

Closed

Description

TS Template added by Matt Bierner (@mjbvz)

TypeScript Version: 3.8.0-dev.20200128

Search Terms

  • call hierarchy
  • provideCallHierarchyIncomingCalls

/cc Ron Buckton (@rbuckton)


re microsoft/vscode#89386

  • use ts3.8-beta
  • show callers of mergeSort
  • 🐛 some entries show as full file paths, instead they should be folder/project relative

Screenshot 2020-01-29 at 15 14 00

Activity

  1. mjbvz commented on Jan 29, 2020

    @mjbvz

    Here's the response that causes this:

    Trace  - 19:46:11.735] <semantic> Response received: provideCallHierarchyIncomingCalls (138). Request took 120 ms. Success: true 
    Result: [
        {
            "from": {
                "name": "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/Users/matb/projects/vscode/src/vs/base/test/common/arrays.test.ts",
                "kind": "module",
                "file": "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/Users/matb/projects/vscode/src/vs/base/test/common/arrays.test.ts",
                "span": {
                    "start": {
                        "line": 1,
                        "offset": 1
                    },
                    "end": {
                        "line": 347,
                        "offset": 1
                    }
                },
                "selectionSpan": {
                    "start": {
                        "line": 1,
                        "offset": 1
                    },
                    "end": {
                        "line": 1,
                        "offset": 1
                    }
                }
            },
            "fromSpans": [
                {
                    "start": {
                        "line": 49,
                        "offset": 53
                    },
                    "end": {
                        "line": 49,
                        "offset": 62
                    }
                },
                {
                    "start": {
                        "line": 55,
                        "offset": 36
                    },
                    "end": {
                        "line": 56,
                        "offset": 1
                    }
                },
                {
                    "start": {
                        "line": 68,
                        "offset": 31
                    },
                    "end": {
                        "line": 68,
                        "offset": 40
                    }
                },
                {
                    "start": {
                        "line": 70,
                        "offset": 30
                    },
                    "end": {
                        "line": 70,
                        "offset": 39
                    }
                },
                {
                    "start": {
                        "line": 99,
                        "offset": 64
                    },
                    "end": {
                        "line": 99,
                        "offset": 73
                    }
                }
            ]
        },
        ...
    
  2. removed their assignment
    on Jan 29, 2020
  3. rbuckton commented on Apr 8, 2020

    @rbuckton
    Contributor

    Related discussion: #31863 (comment)

  4. jrieken commented on Apr 9, 2020

    @jrieken
    ContributorAuthor

    Yeah, should be... Unsure if the file doesn't match the workspace path because of "path formatting" issues?

  5. mjbvz commented on Apr 10, 2020

    @mjbvz

    Fixed for me in the current VS code code base using TS 3.9-nightly

    Screen Shot 2020-04-09 at 7 34 05 PM

    Johannes Rieken (@jrieken) Do you still see this issue?

  6. rbuckton commented on Apr 22, 2020

    @rbuckton
    Contributor

    Johannes Rieken (@jrieken), Matt Bierner (@mjbvz) has there been any further investigation on the VSCode side? I haven't been able to repro this on Windows. Was the original case discovered on an *nix operating system?

  7. andrewbranch commented on Jul 27, 2020

    @andrewbranch
    Member

    Doesn’t repro for me on macOS either. The original screenshot was taken on macOS. Seems like this is fixed.

  8. locked as resolved and limited conversation to collaborators on Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugA bug in TypeScriptRescheduledThis issue was previously scheduled to an earlier milestone

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions