Add useUnknownInCatchVariables -> recommended - #2251
Merged
Conversation
Contributor
Author
|
I think the CI failure is fixed by microsoft/TypeScript-Website-Localizations#135? |
Jack Bates (jablko)
force-pushed
the
patch-24
branch
from
February 3, 2022 15:09
21d30a7 to
2ed02f1
Compare
Orta Therox (orta)
approved these changes
Feb 4, 2022
Orta Therox (orta)
left a comment
Orta Therox (orta)
left a comment
Contributor
There was a problem hiding this comment.
Yeah, I think defaulting to anything we recommend in --init and --strict is a good call 👍🏻
Jake Bailey (jakebailey)
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull the recommended options from
ts.defaultInitCompilerOptionsandts.optionDeclarations[].strictFlag, to pick up future updates, likedefaultsForOptionsandallowedValuesdo.Currently, the only difference is that
useUnknownInCatchVariablesis missing (this change adds it -> recommended).--initdoesn't includeexactOptionalPropertyTypesyet.