Skip to content

Comparison operators ("<", ">") incorrectly interpreted as type parameters #859

Open

Description

TS and JS Grammar Extension version: 0.0.55 / latest

Code

// Contrived because of simplification
let a = 7
let b = {}
if (a < (b as {c: number}).c || a > (b as {c: number}).c) {

}

If statement parsing:

if [keyword.control.conditional.ts, source.ts]
( [meta.brace.round.ts, source.ts]
a [entity.name.function.ts, meta.function-call.ts, source.ts]
< [punctuation.definition.typeparameters.begin.ts, meta.type.parameters.ts, source.ts]
( [meta.brace.round.ts, meta.type.paren.cover.ts, meta.type.parameters.ts, source.ts]
b [entity.name.type.ts, meta.type.paren.cover.ts, meta.type.parameters.ts, source.ts]
as [entity.name.type.ts, meta.type.paren.cover.ts, meta.type.parameters.ts, source.ts]
{ [punctuation.definition.block.ts, meta.object.type.ts, meta.type.paren.cover.ts, meta.type.parameters.ts, source.ts]
c [variable.object.property.ts, meta.definition.property.ts, meta.field.declaration.ts, meta.object.type.ts, meta.type.paren.cover.ts, meta.type.parameters.ts, source.ts]
: [meta.type.annotation.ts, meta.field.declaration.ts, meta.object.type.ts, meta.type.paren.cover.ts, meta.type.parameters.ts, source.ts]
number [support.type.primitive.ts, meta.type.annotation.ts, meta.field.declaration.ts, meta.object.type.ts, meta.type.paren.cover.ts, meta.type.parameters.ts, source.ts]
} [punctuation.definition.block.ts, meta.object.type.ts, meta.type.paren.cover.ts, meta.type.parameters.ts, source.ts]
) [meta.brace.round.ts, meta.type.paren.cover.ts, meta.type.parameters.ts, source.ts]
. [meta.type.parameters.ts, source.ts]
c [entity.name.type.ts, meta.type.parameters.ts, source.ts]
| [keyword.operator.type.ts, meta.type.parameters.ts, source.ts]
| [keyword.operator.type.ts, meta.type.parameters.ts, source.ts]
a [entity.name.type.ts, meta.type.parameters.ts, source.ts]
> [punctuation.definition.typeparameters.begin.ts, meta.type.parameters.ts, source.ts]

(rest is normal)

So like:
if ( a<type>(parameters).c ) {}

Example in vscode:
image

Actual code:
image

Activity

  1. changed the title [-]Complicated assertion/operator bug[/-] [+]Comparison operators ("<", ">") incorrectly interpreted as type parameters[/+] on Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions