Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

lookup table code - #611

Merged
Mathias Soeken (msoeken) merged 18 commits into
microsoft:mainfrom
rajkk1:lookitupselecta
Aug 23, 2022
Merged

lookup table code#611
Mathias Soeken (msoeken) merged 18 commits into
microsoft:mainfrom
rajkk1:lookitupselecta

Conversation

@rajkk1

@rajkk1 Rajiv Krishnakumar (rajkk1) commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Implementation of #607

@ghost

Deleted user (ghost) commented Aug 4, 2022

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@msoeken Mathias Soeken (msoeken) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. That looks really great! I left some comments.

Comment thread Numerics/src/FixedPoint/LookupTable.qs Outdated
Comment thread Numerics/src/FixedPoint/LookupTable.qs
Comment thread Numerics/src/FixedPoint/LookupTable.qs Outdated
Comment thread Numerics/src/FixedPoint/LookupTable.qs Outdated
Comment thread Numerics/src/FixedPoint/LookupTable.qs Outdated
Comment thread Numerics/tests/LookupTableTests.qs Outdated
Comment thread Numerics/tests/LookupTableTests.qs Outdated
Comment thread Numerics/tests/LookupTableTests.qs Outdated
Comment thread Numerics/tests/LookupTableTests.qs Outdated
Comment thread Numerics/tests/LookupTableTests.qs Outdated
Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Co-authored-by: Mathias Soeken <mathias.soeken@gmail.com>
Moved potential efficiency comments of fanning out control qubits from summary to inside the code
Split original summary to summary and remarks

@msoeken Mathias Soeken (msoeken) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the comments. I have left one more comment that includes an example for the docs.

Comment thread Numerics/src/FixedPoint/LookupTable.qs
Comment thread Numerics/tests/LookupTableTests.qs Outdated
@msoeken

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@msoeken

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@msoeken

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@msoeken
Mathias Soeken (msoeken) merged commit 2991f67 into microsoft:main Aug 23, 2022
@rajkk1

Copy link
Copy Markdown
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants