This repository was archived by the owner on Jan 12, 2024. It is now read-only.
ApplyWindowed - #603
Merged
Mathias Soeken (msoeken) merged 8 commits intoJul 20, 2022
Merged
Conversation
Applies an operation windowing over input but with const target qubits
|
|
Adrian Lehmann (adrianleh)
force-pushed
the
feature/apply-windowed
branch
from
July 7, 2022 15:14
2f0fefd to
3f87f06
Compare
See comment on microsoft#602 by @cgranade
Adrian Lehmann (adrianleh)
force-pushed
the
feature/apply-windowed
branch
from
July 7, 2022 21:33
888d2bf to
0e6e244
Compare
Mariia Mykhailova (tcNickolas)
suggested changes
Jul 19, 2022
Mariia Mykhailova (tcNickolas)
left a comment
Mariia Mykhailova (tcNickolas)
left a comment
Contributor
There was a problem hiding this comment.
I left some comments for the main operation, the docs ones can be safely copied to the three other ones. For the sample, I would not copy it over, but rather add a reference from the variants to the first operation so that the example in it can be discovered:
/// # See Also
/// - Microsoft.Quantum.Arrays.ApplyWindowed
Mathias Soeken (msoeken)
approved these changes
Jul 19, 2022
Mathias Soeken (msoeken)
left a comment
Mathias Soeken (msoeken)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution Adrian Lehmann (@adrianleh)
Mariia Mykhailova (tcNickolas)
approved these changes
Jul 19, 2022
Mariia Mykhailova (tcNickolas)
left a comment
Mariia Mykhailova (tcNickolas)
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just one small formatting comment
Co-authored-by: Mariia Mykhailova <michaylova@gmail.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #602