This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Implements #465 - #568
Merged
Merged
Implements #465#568
Conversation
Mathias Soeken (msoeken)
requested a review
from Mariia Mykhailova (tcNickolas)
April 17, 2022 19:24
Mariia Mykhailova (tcNickolas)
approved these changes
Apr 20, 2022
Mariia Mykhailova (tcNickolas)
left a comment
Mariia Mykhailova (tcNickolas)
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a couple of small comments to improve the look of API docs and the test code readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
MultiplyIless restrictive on the input arguments and also improves the implementation by making it less costly. It uses a new operationApplyAndLadder, which is stillinternalbut should go through API review. Merging this PR is not blocked on that.