This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Fixes #444 - #537
Merged
Merged
Conversation
Mathias Soeken (msoeken)
requested review from
Brianna Marshall (bamarsha) and
Mariia Mykhailova (tcNickolas)
March 9, 2022 11:12
Mariia Mykhailova (tcNickolas)
left a comment
Mariia Mykhailova (tcNickolas)
left a comment
Contributor
There was a problem hiding this comment.
The issue mentioned two probabilistic tests, TestEstimateFrequencyBinomial being the second one. Would it make sense to address that one in the same manner here?
…es into msoeken/fix-444
Member
Author
Thanks, I overlooked that one, but pushed a change to address it now. |
Mathias Soeken (msoeken)
requested a review
from Mariia Mykhailova (tcNickolas)
March 10, 2022 12:28
Mariia Mykhailova (tcNickolas)
approved these changes
Mar 10, 2022
Mariia Mykhailova (tcNickolas)
left a comment
Mariia Mykhailova (tcNickolas)
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just one small comment
Co-authored-by: Mariia Mykhailova <mamykhai@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also made some minor changes in the files that were edited.