Expand pre-commit hook to all files - #3
Merged
Roman Lutz (romanlutz) merged 1 commit intoJan 14, 2024
Conversation
Roman Lutz (romanlutz)
marked this pull request as ready for review
January 11, 2024 07:31
Nina Chikanov (nina-msft)
approved these changes
Jan 11, 2024
Nina Chikanov (nina-msft)
left a comment
Nina Chikanov (nina-msft)
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
Roman Lutz (romanlutz)
deleted the
romanlutz/expand_precommit_hook_to_all_files
branch
January 14, 2024 09:07
csinguva (csinguva-cyber)
pushed a commit
to csinguva-cyber/PyRIT
that referenced
this pull request
Sep 2, 2025
Security Analysis Summary: - Total scan findings: 1000+ across 9 security tools - False positive rate: 97% - Confirmed critical vulnerabilities: 2 (addressed in this commit) Fix 1: Jinja2 XSS Vulnerability (CVSS 7.3) - File: models/seed_prompt.py - Issue: Environment(autoescape=False) allows code injection - Impact: Malicious prompt templates could execute JavaScript - Fix: Added autoescape=True to enable XSS protection - Priority: CRITICAL - Direct exploitability in web contexts Fix 2: MD5 Cryptographic Weakness (CVSS 5.5) - File: datasets/dataset_helper.py - Issue: MD5 vulnerable to collision attacks since 2004 - Impact: Could compromise dataset hash validation integrity - Fix: Replaced hashlib.md5() with hashlib.sha256() - Priority: HIGH - Industry standard compliance requirement Validation Context: - Scanners used: Bandit, Semgrep, CodeQL, GitLeaks, TruffleHog, pip-audit, OSV - Manual verification confirmed these as real vulnerabilities - Avoided 1000+ false positive fixes through systematic validation - Total fix time: 15 minutes vs days of chasing false positives Compliance Impact: - Addresses OWASP Top 10 microsoft#3 (XSS) - Eliminates crypto standard violations - Maintains backward compatibility - No functional changes, security hardening only
Roman Lutz (romanlutz)
referenced
this pull request
in romanlutz/PyRIT
Mar 5, 2026
Azure Blob Storage enforces HTTPS by default ('Secure transfer required').
Rejecting HTTP also limits SSRF surface area per review comment #3.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
varunj-msft
added a commit
that referenced
this pull request
Apr 8, 2026
Adrian Gavrila (adrian-gavrila)
pushed a commit
to adrian-gavrila/PyRIT
that referenced
this pull request
Apr 24, 2026
Bundled response to the remaining reviewer comments on the Attack History filter-Combobox migration. microsoft#2/microsoft#3 memory: switch `attack_class` and `targeted_harm_categories` deprecations in `MemoryInterface.get_attack_results` to the project-standard `print_deprecation_message(removed_in="0.15.0")` helper; drop the now-unused `import warnings`. No direct successor exists for `targeted_harm_categories`; point users at `labels={"harm_category": [...]}` (labels supports OR-within-key). microsoft#4 memory/backend: make attack-class matching case-insensitive to match converter-class matching. Removed the explicit `case_sensitive=True` override (default is False in every backend); flipped the regression test to assert lower/upper/mixed casing all match. Service + route docs updated. microsoft#5 frontend: refactor `AttackHistory.fetchAttacks` request-params builder from a stack of seven conditional object spreads into a precomputed, explicitly-guarded `params` object for readability. microsoft#6 frontend: rename `attackClasses` field, `attackClassOptions` prop, `attack-class-filter` testid (and all mirrors) to `attackType*` so they track the server-side `attack_types` query param. microsoft#7 backend: rewrite FastAPI `Query` descriptions for `attack_types`, `converter_types`, and `label` to spell out "May be specified multiple times" semantics with concrete `?key=v1&key=v2` examples. microsoft#8 backend: widen `attack_types` / `converter_types` annotations from `Optional[list[str]]` to `Optional[Sequence[str]]` (matches the already-`Sequence`-typed inner label values). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Richard Lundeen (rlundeen2)
added a commit
to rlundeen2/PyRIT
that referenced
this pull request
Jun 17, 2026
- Reframe 'Executor vs. attack' so the executor/attack contrast leads and attack technique is just a brief pointer to the scenarios docs (microsoft#3) - Reword the Executor categories lead-in so it no longer reads like there are only two families (#1) - Pull Attack Configuration out of the executor list since it is not an executor (#2) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing configuration targets only
$(package_name)which is the package directory. This change expands this to run on all files in the repo.