PowerShellForGitHub: Update Check Fails with an Invalid XML Response

[X-Guardian]

Issue Details

The PowerShellForGitHub update check is failing with an Invalid XML Response.

Steps to reproduce the issue

Import-Module PowerShellForGitHub -Force
Get-GitHubUser -Current -Verbose

Verbose logs showing the problem

VERBOSE: [0.14.0] Executing: Get-GitHubUser -Current:$true -Verbose:$true
VERBOSE: [PowerShellForGitHub] update check failed for today (invalid XML response).  Assuming up-to-date.
VERBOSE: Getting current authenticated user
VERBOSE: Accessing [Get] https://api.github.com/user [Timeout = 0)]
VERBOSE: GET https://api.github.com/user with 0-byte payload
VERBOSE: received 1223-byte response of content type application/json; charset=utf-8
VERBOSE: [0.14.0] Executing: Set-TelemetryEvent -EventName "Get-GitHubUser"
VERBOSE: Sending telemetry event data to https://dc.services.visualstudio.com/v2/track [Timeout = 0)]
VERBOSE: POST https://dc.services.visualstudio.com/v2/track with -1-byte payload
VERBOSE: received 49-byte response of content type application/json; charset=utf-8

Requested Assignment

I'm just reporting this problem, but don't want to fix it.

Operating System

OsName               : Microsoft Windows 10 Pro
OsOperatingSystemSKU : 48
OsArchitecture       : 64-bit
WindowsVersion       : 1903
WindowsBuildLabEx    : 18362.1.amd64fre.19h1_release.190318-1202
OsLanguage           : en-GB
OsMuiLanguages       : {en-GB, en-US}

PowerShell Version

Name                           Value
----                           -----
PSVersion                      5.1.18362.752
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.18362.752
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Module Version

Running: 0.14.0
Installed: 0.14.0

[HowardWolosky]

Thanks for the report. This is a regression introduced by #242 unfortunately when I was reducing the lines in the module that exceeded 100 chars.

Specifically:

PowerShellForGitHub/UpdateCheck.ps1

Line 86 in 17f6122

Write-Log =Message $message -Level Verbose

(note the =Message instead of the -Message)