Skip to content

Code signing remark still valid for labconfig #612

Open

Description

See #609

https://github.com/microsoft/MSLab/releases/tag/v24.11.1

From the changelog I understood that signing got removed Vladimír (@machv), can we remove instructions in readme.md?

Activity

  1. machv commented on Nov 20, 2024

    @machv
    Collaborator

    This change, I hope, is only temporary until I resolve needed changes on the build infrastructure. But as Windows Server 2025 has recently been released, I didn't want to further block MSLAB new release.

  2. Karl-WE commented on Nov 21, 2024

    @Karl-WE
    ContributorAuthor

    Thanks!
    So only labconfig.ps1 will remain unsigned in future? I mean this one needs to be edited and then re-signed anyway.

    This is well described but I wonder why we are doing this in the first place?
    I understand it more for all scripts.

    I never had any issues running Deploy with an unsigned labconfig. That's my point.

    Thank you for your explaination why it's feasible to sign it, while it's a dynamic file.

    Reference
    Also please keep in mind that any change to LabConfig.ps1 file would then require to sign that file again as any change in LabConfig would invalidate initial signature.

    To sign LabConfig.ps1 file you can use this snippet that would select first available Code Signing certificate on your computer:

    Get a Code signing certificate from store $certificate = Get-ChildItem -Path Cert:\CurrentUser\My\ -CodeSigningCert | Select-Object -First 1 # Add signature to a LabConfig file Set-AuthenticodeSignature -FilePath "LabConfig.ps1" -Certificate $certificate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions