Skip to content

update warning presence in Microsoft.Build.Locator.targets - #233

Merged
YuliiaKovalova merged 4 commits into
microsoft:masterfrom
YuliiaKovalova:dev/ykovalova/fix_warning_presence
Sep 13, 2023
Merged

update warning presence in Microsoft.Build.Locator.targets#233
YuliiaKovalova merged 4 commits into
microsoft:masterfrom
YuliiaKovalova:dev/ykovalova/fix_warning_presence

Conversation

@YuliiaKovalova

Copy link
Copy Markdown
Contributor

Fixes: #89

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? It looks like it should hit dotnet/msbuild#1155

@ladipro

Copy link
Copy Markdown
Member

Does this work? It looks like it should hit dotnet/msbuild#1155

+1, this does not build.

YuliiaKovalova, in addition to fixing it could you please also add

  <Import Project="..\..\src\MSBuildLocator\build\Microsoft.Build.Locator.targets"/>

to BuilderApp.csproj so this file is covered by CI?

@YuliiaKovalova

YuliiaKovalova commented Sep 1, 2023

Copy link
Copy Markdown
Contributor Author

Does this work? It looks like it should hit dotnet/msbuild#1155

+1, this does not build.

YuliiaKovalova, in addition to fixing it could you please also add

  <Import Project="..\..\src\MSBuildLocator\build\Microsoft.Build.Locator.targets"/>

to BuilderApp.csproj so this file is covered by CI?

I was inspired by https://stackoverflow.com/questions/3289538/is-there-any-msbuild-task-to-check-if-a-string-contains-another-string-similar

:) I will doublecheck

Should I check it with a regular expression?

@ladipro

Copy link
Copy Markdown
Member

I was inspired by https://stackoverflow.com/questions/3289538/is-there-any-msbuild-task-to-check-if-a-string-contains-another-string-similar

Yes, it works for properties but sadly not for metadata.

Should I check it with a regular expression?

I don't think so. Please check this comment.

@YuliiaKovalova

Copy link
Copy Markdown
Contributor Author

I was inspired by https://stackoverflow.com/questions/3289538/is-there-any-msbuild-task-to-check-if-a-string-contains-another-string-similar

Yes, it works for properties but sadly not for metadata.

Should I check it with a regular expression?

I don't think so. Please check this comment.

It works, thank you !

@ladipro Ladi Prosek (ladipro) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for Rainer Sigwald (@rainersigwald)'s approval before merging.

@YuliiaKovalova

Copy link
Copy Markdown
Contributor Author

Rainer Sigwald (@rainersigwald) , please review the changes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I seem to have totally missed this from a couple of weeks ago. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is it safe to use ExcludeAssets="runtime;contentfiles"?

3 participants