Add support for Login with Multi-Factor Authentication - #735
Merged
Tyler Olson (TYLEROL) merged 8 commits intoFeb 6, 2020
Merged
Conversation
…t disable by default) / Fix Tests is required
…/addMFA # Conflicts: # Microsoft.Dynamics365.UIAutomation.Sample/TestSettings.cs # Microsoft.Dynamics365.UIAutomation.Sample/UCI/Create/CreateOpportunity.cs # Microsoft.Dynamics365.UIAutomation.Sample/UCI/UnifiedInterface.orderedtest
# Conflicts: # Microsoft.Dynamics365.UIAutomation.Api.UCI/WebClient.cs # Microsoft.Dynamics365.UIAutomation.Sample/TestSettings.cs # Microsoft.Dynamics365.UIAutomation.Sample/UCI/Create/CreateOpportunity.cs # Microsoft.Dynamics365.UIAutomation.Sample/UCI/UnifiedInterface.orderedtest + Fix SeleniumExtensions.WaitUntilAvailable
Angel A. Rodriguez (AngelRodriguez8008)
requested review from
Tyler Olson (TYLEROL) and
Daren Turner (dtu11)
January 25, 2020 00:06
Angel A. Rodriguez (AngelRodriguez8008)
changed the title
Angel A. Rodriguez (AngelRodriguez8008)
left a comment
Angel A. Rodriguez (AngelRodriguez8008)
left a comment
Contributor
Author
There was a problem hiding this comment.
Please Tyler Olson (@TYLEROL) approve this PR
Tyler Olson (TYLEROL)
approved these changes
Feb 6, 2020
Contributor
Author
|
Thank you, very much Tyler Olson (@TYLEROL) |
12 tasks
Angel A. Rodriguez (AngelRodriguez8008)
deleted the
users/angel/addMFAwithDriversPath
branch
February 7, 2020 23:30
|
Hi Angel A. Rodriguez (@AngelRodriguez8008) , I see the fix has been merged into develop. Should the Login With MFA be included into a new release anytime soon? |
Contributor
Author
|
Hi tristanperper, Sorry I guest so. But I don't manage the releases, I also work just with the version in 'develop' branch or or one version of my fork. I don't know how oft will be or has been released. br |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Add support for Login with Multi-Factor Authentication
This comment documents the configuration, consider to add to the project Wiki
Issues addressed
Fix #726 Login to support multi-factor authentication (related to #653)
Fix SeleniumExtensions.WaitUntilAvailable (see my comment in #707)
May fix: #721
All submissions:
Which browsers was this tested on?
Daren Turner (@dtu11) it was hard to merge with #734 can you please take a look at the methods:
Tyler Olson (@TYLEROL) in commit: Add MFA Key to UCI Tests, I add the MFA SecrectKey to all UCI Tests. It is a simple change, however, I have none Environment without MFA to tests what happen if is MFA is not required & this Key is set to empty in app.config. Can you please check if it is working?
I wanted add the TestsBase to all UCI sample methods. I stops to doing it because for some unknown reason it broke the UCI Ordered Tests file and I was not sure if it was really desired; for samples porpoise may be not good.