Skip to content

Add knex dependents to expected failures - #840

Merged
Nathan Shively-Sanders (sandersn) merged 2 commits into
masterfrom
knex-failure
Nov 21, 2023
Merged

Add knex dependents to expected failures#840
Nathan Shively-Sanders (sandersn) merged 2 commits into
masterfrom
knex-failure

Conversation

@gabritto

Copy link
Copy Markdown
Member

DT packages that depend on knex (which ships its own types) have started failing on TS 5.4 due to microsoft/TypeScript#56004.

@jakebailey

Copy link
Copy Markdown
Member

expectedFailures.txt is read by the package and not via HTTP, so this change will require a changeset (note the failing build).

You should be able to run pnpm changeset and mash enter until you can add a changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants