Repository navigation
Add mapping from ContractVersion attrib to SupportedOSPlatform attrib for VS compat assistance - #557
Merged
Merged
Conversation
…, for VS compat assistance
Scott Jones (Scottj1s)
requested review from
Jeremy Koritzinsky (jkoritzinsky) and
Manodasan Wignarajah (manodasanW)
November 2, 2020 16:43
Scott Jones (Scottj1s)
force-pushed
the
scottj1s/SupportedOSPlatform
branch
from
January 11, 2021 01:34
839f4b5 to
d53416b
Compare
Scott Jones (Scottj1s)
force-pushed
the
scottj1s/SupportedOSPlatform
branch
from
January 11, 2021 01:35
d53416b to
490ecb5
Compare
Scott Jones (Scottj1s)
requested a review
from Manodasan Wignarajah (manodasanW)
January 11, 2021 18:41
Member
|
APICompat run on Windows SDK projection: The first three might be issues? I wonder if the others really have a API compat issue? |
Member
Author
I removed the metadata attributes because they seemed completely unnecessary at the projection layer (and because some of them were generating CA1416 noise). It's possible someone might be reflecting on them, which would make this a breaking change, but I can't imagine for what purpose. The first 4 are resolved with reverting the WindowsRuntimeStorageExtensions Net5 factoring. |
Manodasan Wignarajah (manodasanW)
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details on how SupportedOSPlatform works, see:
Platform compatibility analyzer
OS version in TFMs
Annotating APIs as unsupported on specific platforms
CA1416: Validate platform compatibility
Note that the SupportedOSPlatform attribute is documented as only valid on:
assembly, module, class, struct, enum, constructor, method, property, indexer, field, event
By experiment, attributes are also supported.
interface, delegate, contract are NOT supported.
fixes #411