Skip to content

Code: DirectLineJS should empty out contentUrl if it is a placeholder #265

Open
Open
Code: DirectLineJS should empty out contentUrl if it is a placeholder#265

Description

@compulim
William Wong (compulim)
opened on Jan 29, 2020

Feature Request

In core/src/reducers/activities.js, we have some code to empty out contentUrl if the attachment should not be downloadable. This code should be moved to DirectLineJS.

// TODO: [P2] This "contentURL" removal code should be moved to DirectLineJS adapter.

[Enhancement]

Activity

  1. corinagum commented on Jan 29, 2020

    @corinagum
    Corina (corinagum)
    on Jan 29, 2020
    Contributor

    do we have a DLJS item tracking this one? :)

  2. Chris Whitten (cwhitten)
    transferred this issue frommicrosoft/BotFramework-WebChaton Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions