Skip to content

rxjs - peer dependency #178

Open
Open
rxjs - peer dependency#178
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.customer-replied-toRequired for internal reporting. Do not delete.customer-reportedRequired for internal Azure reporting. Do not delete.
Milestone
R15

Description

@cheng93
cheng93
opened on Apr 8, 2019

rxjs should be specified as a peer dependency.

This will allow users to use rxjs6 with rxjs-compat.

Currently I get errors such as

Type 'import("c:/Code/AngularWebComponents/node_modules/botframework-directlinejs/node_modules/rxjs/Observable").Observable<import("c:/Code/AngularWebComponents/node_modules/botframework-directlinejs/built/directLine").Activity>' is not assignable to type 'import("c:/Code/AngularWebComponents/node_modules/rxjs/internal/Observable").Observable<import("c:/Code/AngularWebComponents/node_modules/botframework-directlinejs/built/directLine").Activity>'.

Activity

  1. Jim Lewallen (jameslew)
    added
    Customer
    on Jul 23, 2019
  2. Scott Gellock (sgellock)
    removed
    Customer
    on Aug 8, 2019
  3. Chris Whitten (cwhitten)
    added
    Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.
    customer-reportedRequired for internal Azure reporting. Do not delete.
    customer-replied-toRequired for internal reporting. Do not delete.
    on Feb 26, 2021
  4. Chris Whitten (cwhitten)
    added this to the R13 milestone on Feb 26, 2021

  5. cwhitten commented on Feb 26, 2021

    @cwhitten
    Chris Whitten (cwhitten)
    on Feb 26, 2021
    Member

    Loading up for discussion/prioritization in an upcoming release

  6. Kamran Iqbal (Kaiqb)
    removed this from the R13 milestone on Mar 26, 2021
  7. Chris Mullins (cleemullins)
    added this to the R15 milestone on Jun 8, 2021

  8. daniel-scheiner commented on Oct 11, 2023

    @daniel-scheiner
    Dan (daniel-scheiner)
    on Oct 11, 2023

    Hi Chris Whitten (@cwhitten), was this resolved? Looks like rxjs 5.5.12 is still being used and I'm experiencing the issue above. Do you have plans to upgrade rxjs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.customer-replied-toRequired for internal reporting. Do not delete.customer-reportedRequired for internal Azure reporting. Do not delete.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions