fix: change y_col to const int8_t* for Windows Clang build compatibility - #491
Closed
RoomWithOutRoof (Jah-yee) wants to merge 2 commits into
Closed
fix: change y_col to const int8_t* for Windows Clang build compatibility#491RoomWithOutRoof (Jah-yee) wants to merge 2 commits into
RoomWithOutRoof (Jah-yee) wants to merge 2 commits into
Conversation
On Windows with ClangCL, the code at line 811 declares int8_t * but receives a const int8_t *, causing compilation error: cannot initialize a variable of type 'int8_t *' with an rvalue of type 'const int8_t *' This fix adds the const qualifier to match the actual pointer type being assigned.
RoomWithOutRoof (Jah-yee)
force-pushed
the
fix/windows-const-pointer
branch
from
March 19, 2026 00:24
30c3bee to
496fb2a
Compare
On Windows, using -T ClangCL toolset flag conflicts with explicitly setting -DCMAKE_C_COMPILER=clang and -DCMAKE_CXX_COMPILER=clang++. This causes CMake configuration to fail with 'The C compiler identification is unknown'. This fix conditionally passes the compiler flags only on non-Windows platforms, matching the suggestion in issue microsoft#493.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
int8_t * y_coltoconst int8_t * y_colat line 811 insrc/ggml-bitnet-mad.cppProblem
When building on Windows with ClangCL (Clang via Visual Studio 2022 Build Tools), the build fails with:
Solution
The variable
y_colis used withconst int8_t * pyin the subsequent code, so it should also be declared asconst int8_t *.This matches the pattern at line 906 where the same variable is correctly declared as
const int8_t *.Fixes issue #489