Add SCM functional knowledge domain - #192
Open
Jesper Schulz-Wedde (JesperSchulz) wants to merge 2 commits into
Open
Jesper Schulz-Wedde (JesperSchulz) wants to merge 2 commits into
Jesper Schulz-Wedde (JesperSchulz) wants to merge 2 commits into
Conversation
Introduce nine source-backed rules with original AL sample pairs, bounded SCM review routing, and complete positive/clean evaluation coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Align article and AL sample conventions, keep BC facts separate from review mechanics, and clarify reciprocal Finance ownership without bespoke shared test assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce
microsoft/knowledge/scm/: nine scoped functional rules with original, self-contained bad/good AL samples. Independently based on refreshedmain(b91443be), intended to land before #57; no unmerged Finance code or shared-domain abstraction is required.Research is synthesized from Microsoft Learn and BCApps
8f7a04cb(BaseApp source 30.0). No implementation bodies are copied. The posting rule is retained for SCM-specific application/value/tracking invariants and capacity/WIP/temporary-buffer exclusions, not generic engine-use advice.Review feedback and integration
See samplelinks. All 18 AL companions are global and import-free; executable bodies are unchanged.al-scm-reviewis 121 lines instead of 213, retaining deterministic cues, index-first bounded retrieval and the strict mutation/posting-or-supply/demand gate. DO/schema governs output; embedded examples and the SCM-only shared-test block are removed.$expectedLeaves.Countdiagnostics and number-free/common coverage wording.Validation
The exact publication tree was checked after refreshing
origin/main:not-applicablewith zero coverage/findings; mixed Item Ledger+G/L posting yields exactly one SCM primary finding.525e84e.An initial batch-model result had three positional tool-response/case association errors. Its immutable output and audit were retained; scorer controls verified the harness, and confirmation used bound individual requests rather than repairing findings. The independently observed read-only gate weakening was fixed narrowly.
No BC environment deployment or database posting tests were performed. Compilation and source research are separate evidence, not runtime coverage across every BC version.