[Shopify] Show configured product status in Add to Shopify confirmation - #11603
Onat Buyukakkus (onbuyuka) wants to merge 1 commit into
Conversation
Show the configured Active, Draft, or Unlisted product status in the confirmation dialog and cover all three values with regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ce24dc7e-5fe0-4cb1-be3b-919540c321a7
Good Sense Reviewer - Round 1Recommendation: AcceptWhat this PR doesThis change makes the Add to Shopify confirmation use the full configured product status instead of reducing it to active versus non-active. The page now shows the Active, Draft, or Unlisted text that matches the selected shop setting, and the old boolean setter remains available behind the cleanup guard. The fix matches the product creation path: the product already gets its status from the same shop field, and the confirmation now reads that enum directly. The enum has only Active, Draft, and Unlisted values, so the page covers every current status, and the tests exercise all three visible confirmation texts through the real confirmation flow. Problem-solution fitFit: Strong The reported problem is that the confirmation text says Draft when the configured status is Unlisted, even though the created product uses the configured status. The diff addresses that exact mismatch without changing product creation behavior or broadening the workflow. SuggestionsNone. Risk assessment and necessityRisk: The change is limited to the Shopify add-item confirmation page and the two places that pass the selected shop status into it. Compatibility risk is low because the old SetIsActive procedure remains for non-clean builds and now clears the new Unlisted flag when it is used. Necessity: The confirmation must match the configured product status before the user confirms creation. This is a focused UI correctness fix with regression tests for Active, Draft, and Unlisted.
|
Summary
SetIsActivebehindCLEAN30in favor ofSetProductStatus.Test plan
UnitTestAddItemConfirmationShowsActiveStatus.UnitTestAddItemConfirmationShowsDraftStatus.UnitTestAddItemConfirmationShowsUnlistedStatus.Fixes AB#650379