Skip to content

[Shopify] Show configured product status in Add to Shopify confirmation - #11603

Open
Onat Buyukakkus (onbuyuka) wants to merge 1 commit into
mainfrom
bugs/650379-shopify-confirmation-status
Open

Onat Buyukakkus (onbuyuka) wants to merge 1 commit into
mainfrom
bugs/650379-shopify-confirmation-status

Conversation

@onbuyuka

@onbuyuka Onat Buyukakkus (onbuyuka) commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pass the full configured product status to the Add to Shopify confirmation dialog.
  • Show the correct confirmation text for Active, Draft, and Unlisted products.
  • Obsolete SetIsActive behind CLEAN30 in favor of SetProductStatus.
  • Add regression coverage for all three product statuses.

Test plan

  • Built the Shopify Connector app.
  • Ran UnitTestAddItemConfirmationShowsActiveStatus.
  • Ran UnitTestAddItemConfirmationShowsDraftStatus.
  • Ran UnitTestAddItemConfirmationShowsUnlistedStatus.

Fixes AB#650379

Show the configured Active, Draft, or Unlisted product status in the confirmation dialog and cover all three values with regression tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ce24dc7e-5fe0-4cb1-be3b-919540c321a7
@onbuyuka
Onat Buyukakkus (onbuyuka) requested a review from a team as a code owner September 18, 2026 09:32
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Sep 18, 2026
@github-actions github-actions Bot added this to the Version 30.0 milestone Sep 18, 2026
@github-actions github-actions Bot added the Team: Integrations GitHub request for Integrations area label Sep 18, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Good Sense Reviewer - Round 1

Recommendation: Accept

What this PR does

This change makes the Add to Shopify confirmation use the full configured product status instead of reducing it to active versus non-active. The page now shows the Active, Draft, or Unlisted text that matches the selected shop setting, and the old boolean setter remains available behind the cleanup guard.

The fix matches the product creation path: the product already gets its status from the same shop field, and the confirmation now reads that enum directly. The enum has only Active, Draft, and Unlisted values, so the page covers every current status, and the tests exercise all three visible confirmation texts through the real confirmation flow.

Problem-solution fit

Fit: Strong

The reported problem is that the confirmation text says Draft when the configured status is Unlisted, even though the created product uses the configured status. The diff addresses that exact mismatch without changing product creation behavior or broadening the workflow.

Suggestions

None.

Risk assessment and necessity

Risk: The change is limited to the Shopify add-item confirmation page and the two places that pass the selected shop status into it. Compatibility risk is low because the old SetIsActive procedure remains for non-clean builds and now clears the new Unlisted flag when it is used.

Necessity: The confirmation must match the configured product status before the user confirms creation. This is a focused UI correctness fix with regression tests for Active, Draft, and Unlisted.


[AI-PR-REVIEW] version=1 promptVersion=4 system=github pr=11603 round=1 by=alexei-dobriansky at=2026-09-18T22:20:11.5763642Z lastSha=bbca79948b66b5621a97cb770871438da9300aa3 reviewKey=621b93ad55f777456f65d7610ca611cdd1114de252a7549edc49e9a72c85d718 suggestions=none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Team: Integrations GitHub request for Integrations area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants