Turn payment service endpoints into CRUD. - #200
Draft
Gerrit91 wants to merge 8 commits into
Draft
Conversation
This makes our API more consistent and makes it easier to implement and handle for the CLI.
iljarotar
reviewed
Jul 7, 2025
iljarotar
reviewed
Jul 7, 2025
Gerrit91
commented
Jul 8, 2025
Comment on lines
+227
to
+239
| string name = 2; | ||
| // PaymentMethodId at the payment provider, the client receives this from the payment provider and passes it on to the api | ||
| optional string payment_method_id = 5; | ||
| string payment_method_id = 3; | ||
| // Email of the customer to be billed | ||
| optional string email = 6 [(buf.validate.field).string.email = true]; | ||
| string email = 4 [(buf.validate.field).string.email = true]; | ||
| // Card the customer to be billed | ||
| optional Card card = 7; | ||
| Card card = 5; | ||
| // Address is the postal address of the customer to be billed | ||
| Address address = 8; | ||
| Address address = 6; | ||
| // Vat which applies to the customer to be billed | ||
| optional string vat = 9; | ||
| string vat = 7; | ||
| // PhoneNumber of the customer to be billed | ||
| optional string phone_number = 10; | ||
| optional string phone_number = 8; |
Contributor
Author
There was a problem hiding this comment.
Pretty sure that we should add more validations to this. Fields like address must be provided?
Collaborator
There was a problem hiding this comment.
Yes, I think there should more validations in general.
Gerrit91
force-pushed
the
payment-service-crud
branch
from
July 8, 2025 08:32
10c4d51 to
1298609
Compare
iljarotar
reviewed
Aug 28, 2026
| // Balance actual balance of the customer | ||
| optional int64 balance = 13; | ||
| // Tier describes the state in which the customer is using the products. | ||
| ProductTier tier = 14; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes our API more consistent and makes it easier to implement and handle for the CLI.