Repository navigation
Conversation
LZ4F_ENABLE_OBSOLETE_ENUMS is only needed for the unprefixed contentChecksum_t. Use the prefixed type and keep an alias for lz4 <= 1.6.0, so the build no longer depends on the obsolete enum. Fixes: meta#4897 Signed-off-by: mahailiang <mahailiang@uniontech.com>
|
Hi @UOS-liang! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
programs/fileio.cuses the obsolete unprefixedcontentChecksum_tand definesLZ4F_ENABLE_OBSOLETE_ENUMSto get it. lz4 1.11.0 removed that name and 1.11.1 keeps it only as deprecated, so building zstd with LZ4 support warns (and fails with-Werror).Use
LZ4F_contentChecksum_t, drop the obsolete-enums define, and keep a compatibility alias for lz4 <= 1.6.0 where only the unprefixed type exists.Fixes: #4897