Repository navigation
Conversation
Cyan4973
approved these changes
Nov 19, 2026
Cyan4973
left a comment
Contributor
There was a problem hiding this comment.
minor: ZSTD_IS_SUBPROJECT is not documented, and cmake -LH does not list it, since it is a normal variable rather than a cache option. A line in the FetchContent section of build/cmake/README.md would help, for example: set ZSTD_IS_SUBPROJECT before add_subdirectory() or FetchContent_MakeAvailable() to override the detection.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
ZSTD_IS_SUBPROJECTflag, which automatically detects unless caller sets explcitlyclean-allanduninstallavoiding collision with parent project targetsChecklist
A gain in one configuration is not a general gain: see the Performance section of CONTRIBUTING.md.
Tools used