Skip to content

Fix windows package example build error - #4993

Open
jlee303 wants to merge 1 commit into
add-lib-windows-packagefrom
fix-windows-example
Open

jlee303 wants to merge 1 commit into
add-lib-windows-packagefrom
fix-windows-example

Conversation

@jlee303

@jlee303 jlee303 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

What and why

Checklist

  • I searched open pull requests and issues: this problem is not already being addressed.
  • Bug fix: it comes with a reproducer or a test that fails without the fix.
  • Performance change: numbers from repeated runs are included, with CPU, compiler, flags and data.
    A gain in one configuration is not a general gain: see the Performance section of CONTRIBUTING.md.
  • I stated below whether AI or other automated tools were used.

Tools used

  • Claude helped figure out issue and implementation

@meta-cla meta-cla Bot added the CLA Signed label Nov 18, 2026

@Cyan4973 Cyan4973 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the example of the Windows package. But CI has not run here, since the base is the #4992 branch. Once #4992 is merged, rebasing onto dev will run it on the fullbench.c changes, and a push to test_artifacts will run the new MSVC build step.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants