Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WASI libc does not provide
chownorfchown, butUTIL_setFDStatassumes they exist on every non-Windows target. This prevents the CLI source from compiling for WASI. Skip only the ownership updates on WASI; retain permission updates and the existing behavior elsewhere.This surfaced in hermetic-llvm’s multi-stage FDO bootstrap, where an instrumented Clang compiles zstd for each supported target, including WASI, to generate its profile.
Reproducer: this WASI build compiled zstd's
programs/util.cforwasm32-unknown-wasip1and failed withcall to undeclared function 'chown'.wasi-libc's
unistd.hexplicitly notes that WASI has nochown.AI assistance was used to investigate and prepare this patch.