Repository navigation
ci: run playTests.sh against the MSVC build in visual-runtime-tests - #4968
Merged
Merged
Conversation
playTests.sh calls the zstd under test through an alias. bash only expands aliases in a script in POSIX mode, i.e. when started as sh. Started as bash, `zstd` silently runs the zstd found in PATH instead. This happens in visual-runtime-tests: since the alias replaced a function (2ff87ae, 2025-03), playTests.sh there tests the runner's zstd v1.5.7, not the MSVC build. It also happens with `bash playTests.sh` on any machine where zstd is installed. Enable expand_aliases when the script runs in bash.
The step ran under pwsh, which doesn't stop when a program fails, and only reported the exit code of its last command, fuzzer.exe. Since the job was added in 2021, failures of playTests.sh were never reported. The tests now run in their own step, under bash, which stops at the first failing command.
terrelln
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
visual-runtime-testsis meant to runplayTests.shagainst the MSVC build. It doesn't, and it never reports a failure.playTests.shcalls the zstd under test through an alias. bash only expands aliases in a script in POSIX mode, i.e. when started assh.sh -e playTests.sh: the trace shows+ zstd ...instead of+ ./zstd.exe .... So everyzstdcall runs the zstd preinstalled on the runner.*** Zstandard CLI (64-bit) v1.5.7, whilefuzzer.exereports 1.6.0.bash playTests.shon any machine where zstd is installed.fuzzer.exe. Today,playTests.shstops at the junction test of programs: don't follow symbolic links and junctions in -r on Windows #4905, because v1.5.7 follows the junction. The job is still green.Changes:
playTests.shenablesexpand_aliaseswhen it runs in bash. The alias stays: POSIX doesn't requireVAR=value functionto exportVARto the commands the function runs, and tests likeZSTD_NBTHREADS=4 zstd ...rely on it.bash, which stops at the first failing command.Checked locally:
bash playTests.shran/usr/bin/zstdv1.5.5 and failed. After, it runs../programs/zstdand passes.sh playTests.shpasses before and after.This is the first run of
playTests.shagainst the MSVC build since March 2025, so it may expose real failures.