Skip to content

reject out-of-range numFrames in seekable seek table loader - #4717

Merged
Cyan4973 merged 1 commit into
meta:devfrom
saleemno1:seektable-numframes-overflow
Nov 8, 2026
Merged

Cyan4973 merged 1 commit into
meta:devfrom
saleemno1:seektable-numframes-overflow

Conversation

@saleemno1

Copy link
Copy Markdown
Contributor

a corrupt seekable footer can claim any numFrames, and since ZSTD_seekable_loadSeekTable never bounds it against ZSTD_SEEKABLE_MAXFRAMES the way the compressor does, the U32 tableSize math overflows (and the seekEntry_t allocation wraps on 32-bit) into an undersized heap buffer that the fill loop overruns, so this rejects it up front as corruption.

@meta-cla meta-cla Bot added the CLA Signed label Jul 29, 2026
@Cyan4973 Cyan4973 self-assigned this Nov 8, 2026
@Cyan4973 Cyan4973 added the bug label Nov 8, 2026
@Cyan4973

Cyan4973 commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

For some reason, CI tests never ran on this PR.
So I'll close and open it again, in the hope that it would trigger a CI restart.

@Cyan4973 Cyan4973 closed this Nov 8, 2026
@Cyan4973 Cyan4973 reopened this Nov 8, 2026
@Cyan4973
Cyan4973 merged commit 399405a into meta:dev Nov 8, 2026
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants