Repository navigation
Fix 32-bit zstdmt max job size allocation failure - #4675
Open
danyalahmed1995 wants to merge 1 commit into
Open
danyalahmed1995 wants to merge 1 commit into
danyalahmed1995 wants to merge 1 commit into
Conversation
49 tasks
kevinjzhang
pushed a commit
to kevinjzhang/zstd
that referenced
this pull request
Nov 12, 2026
On 32-bit builds, ZSTDMT_initCStream_internal() computed the round buffer size in size_t. With a 1 GiB job (windowLog 30, btultra2, LDM disabled) the 4 GiB total wraps to 0, init succeeds with a 0-byte buffer, and the first streaming copy writes past it. The same wrap happens with many workers at the maximum job size, which PR meta#4675's cap reduction alone does not prevent. Compute the slack/section totals in 64 bits and reject the configuration with memory_allocation when the total exceeds SIZE_MAX, before allocating. Also adopt meta#4675's 32-bit cap reduction (job log 29->28, job size 512 MB->256 MB) so the reported 1-worker, level 22 case needs 1 GiB instead of 2 GiB. Add a 32-bit-only fuzzer regression test that expects the oversized configuration to fail cleanly with memory_allocation, and a bounds test pinning the architecture-specific job size maximum. Fixes meta#4628.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4628.
Summary
Reduces the 32-bit zstdmt maximum job size from 512 MB / log 29 to 256 MB / log 28.
On 32-bit builds, the previous bound could allow a threaded compression configuration at max compression level to attempt an oversized allocation, matching the failure described in #4628.
This follows the issue reporter's diagnosis and proposed cap reduction.
Changes
ZSTDMT_JOBLOG_MAXon 32-bit builds from 29 to 28.ZSTDMT_JOBSIZE_MAXon 32-bit builds from 512 MB to 256 MB.ZSTD_c_jobSizereports the expected architecture-specific upper bound.Validation
git diff --checklinux/386using Debian testing:make cleanmake -j$(nproc)make checkThe temporary validation workflow was kept out of this PR branch.