Repository navigation
[bugs] zstdgrep/grep inconsistencies - #2095
Conversation
|
Could we add some test case for this new capability ? |
|
FreeBSD failed saying it can't find zstdcat? I'm going to re-run it just to make sure it's not just being strange |
|
Nope, that's a real error:( |
|
One may need to setup a local FreeBSD VM to reproduce the issue and better diagnose it. |
I'll try that quick guess fix first. If that doesn't work, I'll setup of a local VM:/ |
ed1645b to
7b0d267
Compare
|
Okay that seemed to fix it. It was just a matter of adding ZCAT= in front. I'm going to include some other fixes from that issue in this PR too |
|
I tested zstdgrep on the list from the issue and these changes take care of everything but the bash stuff at the end. These: |
14f86b2 to
1b6d39b
Compare
|
Okay, I think this is ready to merge. The only unsupported functionality are the the bash commands listed at the end of that issue but it looks like zgrep produces strange results for those too (so I don't think its worth trying to fix them for zstdgrep). |
|
Could we add a few tests showing off the new capabilities ? |
|
Ah it looks like I deleted the changes to playTests when I force pushed. Yes. I"ll add those back |
|
Looks good to me ! |
Fixing zstdgrep inconsistencies listed on #2064
See each commit message for details