Skip to content

Fix #1428 - zstdgrep now returns 1 on unmatch - #1430

Merged
Cyan4973 merged 3 commits into
meta:devfrom
tesuji:fix-zstdgrep
Nov 28, 2018
Merged

Cyan4973 merged 3 commits into
meta:devfrom
tesuji:fix-zstdgrep

Conversation

@tesuji

@tesuji tesuji commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

Fix some shellcheck warnings.

@Cyan4973

Copy link
Copy Markdown
Contributor

Thanks for this timely fix @lzutao !

Would it be possible to add a test of zstdgrep ?
It would typically be added to, or triggered from, tests/Makefile.

@Cyan4973

Copy link
Copy Markdown
Contributor

Thanks @lzutao !

@Cyan4973
Cyan4973 merged commit f6591e4 into meta:dev Nov 28, 2018
@tesuji
tesuji deleted the fix-zstdgrep branch November 29, 2018 03:30
@Cyan4973

Cyan4973 commented Jan 5, 2019

Copy link
Copy Markdown
Contributor

It seems this introduced a new problem :
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants