This repository was archived by the owner on Mar 22, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Mar 22, 2022. It is now read-only.
Infinite loop on pushing to array #67
Description
I'm using Node.JS version 0.10.26 with Watch.JS stored locally instead of using NPM (as the NPM version doesn't work).
When I push to an array within an object, Watch.JS seems to get stuck in an infinite loop.
var watchjs = require("./app/utils/watch"), // watchjs.watch(obj, function (prop, action, difference, oldvalue), <int> levels, true);
obj = {"objectpacks": {"model_ids": ["ABCD"]}};
function watch(prop, action, difference, oldvalue) {
watchjs.noMore = true;
console.log("WATCH | Prop:", prop);
console.log("WATCH | Action:", action);
console.log("WATCH | Difference:", difference);
console.log("WATCH | Oldvalue:", oldvalue);
}
watchjs.watch(obj, watch, 10, true);
function test() {
console.log("Pushing.");
obj.objectpacks.model_ids.push("test");
}
setTimeout(test, 2000);Results in the following output..
Pushing.
WATCH | Prop: model_ids
WATCH | Action: push
WATCH | Difference: { '0': 'test' }
WATCH | Oldvalue: undefined
WATCH | Prop: objectpacks
WATCH | Action: differentattr
WATCH | Difference: { added: [ 'ABCD,test' ], removed: [] }
WATCH | Oldvalue: { model_ids: [ [Getter/Setter], 'test' ] }
WATCH | Prop: objectpacks
WATCH | Action: differentattr
WATCH | Difference: { added: [ 'ABCD,test' ], removed: [ 'ABCD,test' ] }
WATCH | Oldvalue: { model_ids: [ [Getter/Setter], 'test' ],
'ABCD,test': undefined }
WATCH | Prop: objectpacks
WATCH | Action: differentattr
WATCH | Difference: { added: [ 'ABCD,test' ], removed: [ 'ABCD,test' ] }
WATCH | Oldvalue: { model_ids: [ [Getter/Setter], 'test' ],
'ABCD,test': undefined }
WATCH | Prop: objectpacks
WATCH | Action: differentattr
WATCH | Difference: { added: [ 'ABCD,test' ], removed: [ 'ABCD,test' ] }
WATCH | Oldvalue: { model_ids: [ [Getter/Setter], 'test' ],
'ABCD,test': undefined }
This loops until it's killed.
Any ideas?
Activity
gdude2002 commentedon Mar 5, 2014
Removing the 10 from the function here does solve the problem, but why?
rcleozier commentedon Sep 15, 2014
Bump... Having the same exact issue
seawolff commentedon Oct 28, 2014
Same issue here, even unwatching after first iteration causes a complete crash. In Chrome 38 in case it's useful.
gdude2002 commentedon Oct 28, 2014
I'm not hopeful that the dev will respond here, but please remember to post your code, @rcleozier and @seawolff
seawolff commentedon Oct 29, 2014
@gdude2002 Here is my code. It's abbreviated and in CoffeeScript though:
However to reproduce simply watch a bound array on an object and push data into it.
melanke commentedon Oct 31, 2014
Sorry guys, anything I can help you with? I am not currently working on Watch. Sorry about that, but any pull request will be appreciated
seawolff commentedon Nov 13, 2014
@melanke yeah, same. I'll get a PR open ASAP