fix(test): green dev tip validation - #22
Merged
Merged
Conversation
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes anomalyco#37321 (anomalyco#37321)
Type of change
What does this PR do?
This PR fixes test-only assumptions exposed by the finish-tool change. Scripted LLM fixtures explicitly opt out of the finish tool and reply-style prompt where exact legacy payloads are asserted. The HttpApi exerciser uses a local model catalog instead of making a network request, and its fake LLM configuration preserves legacy prompt behavior. CLI subprocess scenarios use the live clock because they exercise real subprocess wall-clock behavior; they remain concurrent. The TUI test now uses the current plugin-runtime API, and the generated client and SDK types are refreshed.
No production behavior is changed by these test and generated-artifact updates.
How did you verify your code works?
GITHUB_ACTIONS=false bun turbo testbun run test:httpapiNODE_OPTIONS=--max-old-space-size=3072 bun turbo typecheck --concurrency=1bun run check:generatedScreenshots / recordings
Not applicable; this PR does not change UI behavior.
Checklist
If you do not follow this template your PR will be automatically rejected.