Feature/apple music artwork - #33
Open
HrishikeshBhandarkar wants to merge 4 commits into
Open
HrishikeshBhandarkar wants to merge 4 commits into
HrishikeshBhandarkar wants to merge 4 commits into
Conversation
…PlayerView for live artwork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple Music Artwork Models, Scraper & 1080p ExoPlayer Track Selection
What this PR does
This PR introduces the backend data models and scraping service for Apple Music artwork and motion covers, along with a 1080p resolution cap on video playback in
media3-ui.This is the
corecompanion PR required by the SimpMusic UI pull request for Apple Music Live Motion Artwork.Changes
Apple Music Artwork Scraper (
lyricsService):AppleMusicArtworkServiceand supporting data models (AMArtworkModels.kt).{w}x{h})..m3u8playlists for square and tall formats).SimpMusicLyricsClientandSimpMusicLyrics.Domain & Data Repositories (
domain,data):AppleMusicArtworkdomain entity.LyricsCanvasRepositorywithgetAppleMusicSongArtworkandgetAppleMusicAlbumArtworkreturningFlow<Resource<AppleMusicArtwork>>.1080p Cap in ExoPlayer (
media3-ui):DefaultTrackSelectorinMediaPlayerViewwithsetMaxVideoSize(1920, 1920).onPlayerErrorlistener for diagnostics.How it was tested
AppleMusicArtworkService.MediaPlayerViewin both player and album screens../gradlew :media3-ui:compileDebugKotlinand:lyricsService:compileAndroidMain.