Conversation
e5b26e0 to
0a4f801
Compare
0a4f801 to
fc439ae
Compare
|
Hi @maxrave-dev, I've updated this PR for the core used by SimpMusic v2.1.0 and reconciled it with the upstream transport and restoration changes. The focus remains Android Auto Home/Search selection, queue navigation availability, and consistent playback intent/audio focus through MediaSession. The Android build and all 12 Media3 unit tests pass, including two new transport regression tests. I've also built an updated APK for device testing and refreshed the description with the scope and validation limitations. When you have time, could you take a look? Feedback on the forwarding-player/adapter queue ownership approach would be especially helpful. Thank you! |
Keep MediaSession transport routed through the crossfade adapter, require fresh audio focus before playback starts, and preserve adapter-owned queues during browse and search selections. Publish transport command changes promptly, remove duplicate next/previous dispatch, and cover denied-focus and synchronous transport ordering with regression tests.
fc439ae to
3b13369
Compare
|
Updated this PR onto the current The functional fixes remain focused on Android Auto selection, adapter-owned queues, MediaSession transport, audio focus, restoration, and Next/Previous command refresh. The v2.1.0-only The replacement commit is SSH-signed and GitHub-verified. Compile, all 12 Media3 tests, and the Android debug build pass, and the updated build was exercised on a physical phone with Android Auto DHU, including Home/Search/For You playback, restore behavior, and focus handoff with other media apps. When you have time, could you please review the updated v2.2.0-compatible diff? Thank you. |
Summary
Stabilize Android Auto browse/search playback, MediaSession transport, audio-focus handling, queue restoration, and Next/Previous availability with the adapter-owned crossfade player.
This revision is rebased onto the current
multiplatformcore used by SimpMusic v2.2.0 (0b9ce7b). It supersedes the previous v2.1.0 patch while preserving the same functional intent.Problems addressed
PLAYINGafter process restoration while producing no audio until a different browse item was selected.Implementation
CrossfadeExoPlayerAdapterbefore delegate transport.AUDIOFOCUS_LOSS.v2.2.0 reconciliation
SimpMusic v2.2.0 now has a stronger upstream queue restoration and
onPlaybackResumptionimplementation. This revision intentionally retains that upstream implementation and removes the older PR's custom resumption override andMediaServiceHandlerImplrestore workaround. Applying the previous v2.1.0 patch unchanged would create twoonPlaybackResumptionoverrides after merging with currentmultiplatform.The resulting diff is limited to three Media3 production files and one regression-test file. It contains no app icon, artwork, desktop playback, database, networking, recommendation, or UI changes.
Validation
:media3:compileDebugKotlin— passed.:media3:testDebugUnitTest— 12 tests passed, 0 failed.:androidApp:assembleDebug— passed against SimpMusic v2.2.0.The tests cover the transport and ordering regressions; broader vehicle, OEM, Cast, and crossfade combinations still benefit from maintainer testing.
Core commit:
3b13369, signed and GitHub-verified. No APK binaries are included in this PR.